Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: [NFC] Split irdl.py #2705

Merged
merged 18 commits into from
Jun 25, 2024
Merged

core: [NFC] Split irdl.py #2705

merged 18 commits into from
Jun 25, 2024

Conversation

PapyChacal
Copy link
Collaborator

No description provided.

@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Jun 11, 2024
@PapyChacal PapyChacal requested a review from math-fehr June 11, 2024 13:02
@PapyChacal PapyChacal self-assigned this Jun 11, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (5405b85) to head (c71d156).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   89.80%   89.80%   -0.01%     
==========================================
  Files         376      379       +3     
  Lines       48091    48116      +25     
  Branches     7371     7371              
==========================================
+ Hits        43187    43209      +22     
- Misses       3756     3757       +1     
- Partials     1148     1150       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review June 11, 2024 13:16
superlopuh
superlopuh approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :)

math-fehr
math-fehr approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the lord's work, thanks a lot 🙏

xdsl/irdl/common.py Outdated Show resolved Hide resolved
@superlopuh superlopuh changed the base branch from emilien/range-variable to main June 25, 2024 12:01
@superlopuh
Copy link
Member

I moved around the branches to merge the split before the RangeConstraint PR, to unblock other changes that would have touched irdl.py

@PapyChacal PapyChacal merged commit ad76f51 into main Jun 25, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/irdl-split branch June 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@math-fehr math-fehr math-fehr approved these changes

@georgebisbas georgebisbas georgebisbas approved these changes

@AntonLydike AntonLydike AntonLydike approved these changes

@superlopuh superlopuh superlopuh approved these changes

Assignees

@PapyChacal PapyChacal

Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PapyChacal @superlopuh @AntonLydike @georgebisbas @math-fehr